-
Notifications
You must be signed in to change notification settings - Fork 2
chore: upgrade MUI to v7 and Storybook to v10 #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
braianj
wants to merge
4
commits into
master
Choose a base branch
from
feat/upgrade-mui-and-storybook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade Storybook to 9.0.18 and update addons/config - Upgrade MUI to 7.3.7 and remove deep imports / deprecated entrypoints - Fix stories typings for SB9 (blocks, ArgTypes, defaultValue summaries) - Fix build/test configs (ignore dist tests in Jest) - Export missing components (AssetImage, Atlas) and add dclButton namespace
Deploying ui2 with
|
| Latest commit: |
860eb1b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0cc4c22b.ui2-423.pages.dev |
| Branch Preview URL: | https://feat-upgrade-mui-and-storybo.ui2-423.pages.dev |
- Replace extendTheme with createTheme({ cssVariables: true, colorSchemes })
- Update ThemeProvider from CssVarsProvider to MuiThemeProvider
- Update Storybook preview to use useColorScheme hook for theme switching
- Migrate styled imports from @emotion/styled to @mui/material
- Add shouldForwardProp to prevent custom props from reaching DOM
- Add color fallbacks for RarityBadge when theme.palette.rarities is undefined
cyaiox
reviewed
Jan 30, 2026
| if (isMobile) { | ||
| mobileStyles = { | ||
| zIndex: zIndex.appBar, | ||
| zIndex: theme!.zIndex.appBar, |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| zIndex: theme!.zIndex.appBar, | |
| zIndex: theme.zIndex.appBar, |
cyaiox
reviewed
Jan 30, 2026
| left: 0, | ||
| marginLeft: 0, | ||
| zIndex: zIndex.mobileStepper, | ||
| zIndex: theme!.zIndex.mobileStepper, |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove the ! in these lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.