-
Notifications
You must be signed in to change notification settings - Fork 3
feat(vm): support network configuration without a 'Main' network #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LopatinDmitr
wants to merge
10
commits into
main
Choose a base branch
from
feat/vm/support-configuration-without-main-network
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(vm): support network configuration without a 'Main' network #1818
LopatinDmitr
wants to merge
10
commits into
main
from
feat/vm/support-configuration-without-main-network
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
079d50f to
eca0f5b
Compare
bb73f3d to
e4ffe1b
Compare
f15923a to
e246566
Compare
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
e246566 to
1df8134
Compare
e6e3d8a to
d4b00b7
Compare
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
d4b00b7 to
4606660
Compare
Contributor
|
Workflow has started. The target step completed with status: failure. |
Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
Contributor
|
Workflow has started. The target step completed with status: failure. |
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com> # Conflicts: # build/components/versions.yml
b454ae9 to
0e059f4
Compare
…-without-main-network Signed-off-by: Daniil Loktev <70405899+loktev-d@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for configuring virtual machines without a 'Main' network type in the spec.networks list.
Key changes:
Why do we need it, and what problem does it solve?
This enables more flexible network configurations for virtual machines. Users may want to create VMs that only use additional networks (via SDN module) without the default pod network. Previously, the Main network was mandatory, which forced all VMs to have the default pod network interface even when it wasn't needed.
What is the expected result?
Checklist
Changelog entries