Skip to content

fix(vm): skip validation for VMs in terminating status #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hardcoretime wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(vm): skip validation for VMs in terminating status #1842

hardcoretime wants to merge 1 commit into from

Conversation

@hardcoretime
Copy link
Contributor

@hardcoretime hardcoretime commented Dec 19, 2025 •
edited
Loading

Why do we need it, and what problem does it solve?

To prevent reconciliation errors when the Virtualization Controller attempts to remove finalizers from VMs in the terminating status.

What is the expected result?

The VMs must be deleted properly.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: "Skipping validation for VMs in terminating status."
impact_level: low

fix(vm): skip validation for VMs in terminating status
1838a6b 
To prevent reconciliation errors when the Virtualization Controller attempts
to remove finalizers from VMs in the terminating status.

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
@hardcoretime hardcoretime added this to the v1.4.0 milestone Dec 19, 2025
@hardcoretime hardcoretime added the e2e/run Run e2e test on cluster of PR author label Dec 19, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 19, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 19, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 19, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

1 similar comment
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 19, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@hardcoretime hardcoretime

Labels

None yet

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hardcoretime @deckhouse-BOaTswain