Skip to content

perf: adding async to Analytics #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuriassuncx wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf: adding async to Analytics #221

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78bcd2d
perf: adding defer to Analytics
yuriassuncx Sep 5, 2023
297abe5
feat (Analytics): adding property that turns defer attribute active
yuriassuncx Sep 5, 2023
4d263fd
fix (Analytics): changing defer to async
yuriassuncx Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion components/Analytics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,14 @@ export interface Props {
* @description run GTM directly on the main thread, without Partytown. This is useful for debugging purposes. Default: false
*/
dangerouslyRunOnMainThread?: boolean;
/**
* @description turns async attribute on script true or false. Default: false
*/
isAsyncAttributeActiveOnScript?: boolean;
}

export default function Analtyics(
{ trackingIds, src, dangerouslyRunOnMainThread, googleAnalyticsIds }: Props,
{ trackingIds, src, dangerouslyRunOnMainThread, googleAnalyticsIds, isAsyncAttributeActiveOnScript }: Props,
) {
const isDeploy = !!context.isDeploy;
return (
Expand Down Expand Up @@ -67,6 +71,7 @@ export default function Analtyics(
<script
type="module"
id="analytics-script"
async={isAsyncAttributeActiveOnScript}
dangerouslySetInnerHTML={{
__html:
`window.DECO_SITES_STD = { sendAnalyticsEvent: ${sendAnalyticsEvent.toString()} }`,
Expand Down