rpcclient: Authorization header is only needed by AuthTypeBasic #3586
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
reviewed
Dec 9, 2025
| auth := "Basic " + base64.StdEncoding.EncodeToString([]byte(login)) | ||
| requestHeader := make(http.Header) | ||
| requestHeader.Add("Authorization", auth) | ||
| var requestHeader http.Header |
Member
There was a problem hiding this comment.
looks ok, since reads of a nil map is allowed.
| // request header with the Authorization header set. | ||
| login := config.User + ":" + config.Pass | ||
| auth := "Basic " + base64.StdEncoding.EncodeToString([]byte(login)) | ||
| requestHeader = make(http.Header) |
Member
There was a problem hiding this comment.
is this needed or does Add handle the nil receiver?
if it is needed, it seems like the nil variable is really not ok anywhere.
Member
There was a problem hiding this comment.
it is needed, but this seems fine due to go's map semantics and how reads of nil maps is ok, but writes are not.
jrick
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.