[WIP] Implementation of 2D crystal former#7
Open
Br0kenSmi1e wants to merge 43 commits intodeepmodeling:mainfrom
Open
[WIP] Implementation of 2D crystal former#7Br0kenSmi1e wants to merge 43 commits intodeepmodeling:mainfrom
Br0kenSmi1e wants to merge 43 commits intodeepmodeling:mainfrom
Conversation
added 30 commits
October 30, 2024 17:11
added 4 commits
November 20, 2024 11:18
Author
|
Layer group functions and corresponding tests added. |
added 2 commits
November 24, 2024 18:42
GiggleLiu
reviewed
Nov 27, 2024
GiggleLiu
left a comment
GiggleLiu
left a comment
There was a problem hiding this comment.
Tests are well written 👍🏾 . Please clean up the repo.
There was a problem hiding this comment.
If this dataset is for testing, maybe move it to the test folder?
There was a problem hiding this comment.
What is the difference between these two files? Why not convert the items to list in a programmatical way?
| from crystalformer.src.lattice import symmetrize_lattice | ||
| from crystalformer.src.wyckoff import mult_table, symops | ||
| from crystalformer.src.sym_group import * | ||
| # from crystalformer.src.lattice import symmetrize_lattice |
|
|
||
| import numpy as np | ||
| np.set_printoptions(threshold=np.inf) | ||
| # import numpy as np |
| x = jnp.array([0.123, 0.123, 0.25]) | ||
| y = project_x(g, w, x, idx) | ||
| assert jnp.allclose(y, jnp.array([0.877, 0.877, 0.75])) | ||
| # x = jnp.array([0.123, 0.123, 0.25]) |
|
|
||
| # def test_symmetrize_atoms(): | ||
| # from crystalformer.src.wyckoff import symmetrize_atoms | ||
| # from pymatgen.symmetry.groups import SpaceGroup |
|
|
||
|
|
||
| # ============= params to control the generation ============= | ||
| spacegroup = 2 # 设置生成的晶体的空间群，范围为1-230 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not ready yet.