Add some assertions that are helpful for trouble shooting. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add check.py in utils: parse the input cv files with PLUMED before running the workflow. 2. add assertions in submit.py and run_select.py to ensure the trust_lvl_1 and std_threshold to be suitable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Checking input CV files
If there got a problem in the input CV files, these commits allow rid-kit to transmit the raw error messages produced by PLUMED to users for debug.
Rid-kit provides little corresponding information in the workflow log file and only records a "CUDA error #1" in the gmx log. The check.py called by the newly added assertion parses the CV files with PLUMED in advance to ensure their validity and facilitating trouble-shooting.
2. Assertions about trust_lvl_1 and std_threshold
Too large trust_lvl_1 and too small std_threshold may emit all the data points from the training set and interrupt the workflow. When this happens, these assertions allow rid-kit to inform users to adjust the parameters.