Skip to content

chore: package invocations with dotenv#199

Open
AmberFryar wants to merge 1 commit intomainfrom
187-simplify-vitest-invocations-in-packagejson
Open

chore: package invocations with dotenv#199
AmberFryar wants to merge 1 commit intomainfrom
187-simplify-vitest-invocations-in-packagejson

Conversation

@AmberFryar
Copy link
Contributor

@AmberFryar AmberFryar commented Feb 4, 2026

The --env-file=.env CLI flag was necessary for local development so it could discover the version tags and run tests. dotenv dependency has the same effect, except that it is a runtime import. This allows for the invocations to be functional without the CLI flag. Because of the timing difference between dotenv and the CLI flag, imports on vitest and astro config were necessary. The end result is the same, but this dependency allows for a cleaner implementation.

@AmberFryar AmberFryar requested a review from a team as a code owner February 4, 2026 16:24
@AmberFryar AmberFryar linked an issue Feb 4, 2026 that may be closed by this pull request
4 tasks
@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for pepr-docs ready!

Name Link
🔨 Latest commit 3b3fd74
🔍 Latest deploy log https://app.netlify.com/projects/pepr-docs/deploys/698372d79675990009f26f7b
😎 Deploy Preview https://deploy-preview-199--pepr-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🟢 up 24 from production)
Accessibility: 94 (no change from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds dotenv, but I don't see a .env file as part of the project. Do we expect devs to maintain their own .env file outside of version control?

@AmberFryar
Copy link
Contributor Author

AmberFryar commented Feb 10, 2026

This PR adds dotenv, but I don't see a .env file as part of the project. Do we expect devs to maintain their own .env file outside of version control?

@samayer12 Devs currently (before and after this change) need a .env to set the CORE path. The local clone of Pepr allows semver to find the git tags for the versions for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify vitest Invocations in package.json

2 participants