Skip to content

Conversation

@aa-eyup
Copy link

@aa-eyup aa-eyup commented Jun 4, 2023

Summary

Assert chained delegations can not be used to transfer more ERC20 tokens than the root delegation permits. Tests a scenario where an initial delegation allows some amount X of ERC20 transfer which is then re-delegated allowing some amount >X and asserts that some amount >X can not be transferred.
Impacts test files only.

Motivation

  • ERC20 Allowance caveats are enforced at the delegation level using a mapping from a delegation hash, so this change is meant to check the integrity of the root delegation's caveat enforcement.

@aa-eyup aa-eyup force-pushed the test_root_delegation_caveat_enforcement branch from 3543930 to b797f96 Compare June 4, 2023 02:00
@aa-eyup aa-eyup changed the title test: assert chained delegations can not be used to transfer more ERC… test: assert root delegation caveat enforcement Jun 4, 2023
@aa-eyup aa-eyup marked this pull request as ready for review June 4, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant