Skip to content

Remove miles from portfolio #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DannyDelott merged 1 commit into from
May 14, 2025
Merged

Remove miles from portfolio #1845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions apps/hyperdrive-trading/src/rewards/merklUserRewards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,6 @@ interface MerklUserReward {
}

const merklRewards: MerklRewardConfig[] = [
{
id: "miles",
// Merkl.xyz accumulates Miles across all chains and hyperdrives onto Gnosis
// chain only. This makes things easier for turning them into HD later if
// they're all just on one chain.
rewardChainIds: [gnosis.id],
predicate: (reward) => {
return reward.token.symbol === "Miles";
},
},
{
id: "bigShortEnergy",
// Big Short Energy distributes dai on mainnet or xdai on gnosis chain
Expand Down
12 changes: 0 additions & 12 deletions ...ive-trading/src/ui/portfolio/lp/LpAndWithdrawalSharesTable/LpAndWithdrawalSharesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {
AppConfig,
getAddLiquidityRewardConfigs,
getBaseToken,
HyperdriveConfig,
} from "@delvtech/hyperdrive-appconfig";
Expand All @@ -23,7 +22,6 @@ import { TotalLpValue } from "src/ui/portfolio/lp/LpAndWithdrawalSharesTable/Tot
import { WithdrawalQueueCell } from "src/ui/portfolio/lp/LpAndWithdrawalSharesTable/WithdrawalQueueCell";
import { usePortfolioLpDataFromHyperdrives } from "src/ui/portfolio/lp/usePortfolioLpData";
import { PositionTableHeading } from "src/ui/portfolio/PositionTableHeading";
import { PoolHasRewardsBanner } from "src/ui/portfolio/rewards/PoolHasRewardsBanner";
import { Address } from "viem";

export function OpenLpTableDesktop({
Expand Down Expand Up @@ -74,15 +72,6 @@ export function OpenLpTableDesktop({
return null;
}

const poolHasRewards = hyperdrives.some((hyperdrive) => {
const rewardConfigs = getAddLiquidityRewardConfigs({
appConfig,
chainId: hyperdrive.chainId,
hyperdriveAddress: hyperdrive.address,
});
return !!rewardConfigs?.length;
});

return (
<div className="flex flex-col gap-6">
<PositionTableHeading
Expand All @@ -102,7 +91,6 @@ export function OpenLpTableDesktop({
hyperdrives[0].name.replace(/\d{1,3}d/, "")
}
/>
{poolHasRewards ? <PoolHasRewardsBanner /> : null}
<div className="daisy-card overflow-x-clip rounded-box bg-gray-750 pt-3">
<table className="daisy-table daisy-table-lg">
<thead>
Expand Down
2 changes: 0 additions & 2 deletions apps/hyperdrive-trading/src/ui/portfolio/shorts/OpenShortsTable/OpenShortsTableDesktop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { StatusCell } from "src/ui/hyperdrive/longs/StatusCell";
import { MaturesOnCell } from "src/ui/hyperdrive/MaturesOnCell/MaturesOnCell";
import { CloseShortModalButton } from "src/ui/hyperdrive/shorts/CloseShortModalButton/CloseShortModalButton";
import { PositionTableHeading } from "src/ui/portfolio/PositionTableHeading";
import { PoolHasRewardsBanner } from "src/ui/portfolio/rewards/PoolHasRewardsBanner";
import { CurrentShortsValueCell } from "src/ui/portfolio/shorts/OpenShortsTable/CurrentShortsValueCell";
import { ManageShortButton } from "src/ui/portfolio/shorts/OpenShortsTable/ManageShortButton";
import { ShortRateAndSizeCell } from "src/ui/portfolio/shorts/OpenShortsTable/ShortRateAndSizeCell";
Expand Down Expand Up @@ -107,7 +106,6 @@ export function OpenShortsTableDesktop({
hyperdrives[0].name.replace(/\d{1,3}d/, "")
}
/>
{poolHasRewards ? <PoolHasRewardsBanner /> : null}
<div className="daisy-card overflow-x-clip rounded-box bg-gray-750 pt-3">
{/* Modal needs to be rendered outside of the table so that dialog can be used. Otherwise react throws a dom nesting error */}
{tableInstance.getRowModel().rows.map((row) => {
Expand Down
Loading