Update newick definition to be more in-line with my interpretation of the newick standard#173
Open
tommy-mor wants to merge 1 commit intodendrograms:mainfrom
Open
Update newick definition to be more in-line with my interpretation of the newick standard#173tommy-mor wants to merge 1 commit intodendrograms:mainfrom
tommy-mor wants to merge 1 commit intodendrograms:mainfrom
Conversation
Contributor
|
This is a fairly major change and should be accompanied with some documentation, and perhaps tests. Also... this can't be the only place the Newick format is used, is it? |
Author
|
Agreed. I am looking into it and just documenting my process here |
Author
|
Also just posting this to see what other people think. Do you agree something seems fishy here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://en.wikipedia.org/wiki/Newick_format