Skip to content

Conversation

@ignacionistal
Copy link
Contributor

Title*

[Provide a succinct and descriptive title for the pull request, e.g., "Improve caching mechanism for API calls"]

Type of Change*

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Added a new UI button for Sign In with Google action

Testing*

Visual testing on browser that the button is visible and follows Figma design as well as Google branding guidelines.

Impact

No impact to application, just adding UI button without functionality. Only impact would be visible button without any action in Signin UI.

Additional Information

Screenshot 2026-01-28 at 10 06 30 AM

Checklist*

  • No new errors or warnings have been introduced.
  • All tests pass successfully and new tests added as necessary.
  • Documentation has been updated accordingly.
  • Code adheres to the coding and style guidelines of the project.
  • Code has been commented in particularly hard-to-understand areas.

@ignacionistal ignacionistal changed the title Feat/add google sign in UI button Feat: add google sign in UI button Jan 29, 2026
@ignacionistal ignacionistal changed the title Feat: add google sign in UI button feat: add google sign in UI button Jan 29, 2026
@ignacionistal ignacionistal force-pushed the feat/AddGoogleSignInUIButton branch from 2e3a7dc to 63b68bc Compare January 29, 2026 16:32
@juanarroqui juanarroqui requested a review from Copilot January 29, 2026 20:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Google Sign In button to the sign-in page UI, following Google branding guidelines and Figma design specifications. The button currently has no functionality and serves as a placeholder for future OAuth implementation.

Changes:

  • Added a non-functional Google Sign In button to the sign-in form with appropriate styling
  • Added a visual separator ("OR") between Google sign-in and traditional email/password form
  • Added the @iconify-json/logos package to support the Google icon

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/front-end/src/app/pages/signin.vue Added Google Sign In button component with placeholder handler and visual separator
packages/front-end/package.json Added @iconify-json/logos dependency for Google icon support
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ignacionistal ignacionistal force-pushed the feat/AddGoogleSignInUIButton branch from 63b68bc to df011fd Compare February 3, 2026 15:29
@ignacionistal ignacionistal merged commit d9609d0 into development Feb 3, 2026
1 check passed
@ignacionistal ignacionistal deleted the feat/AddGoogleSignInUIButton branch February 3, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants