Add Docker support and installation instructions #3
Conversation
…e, and docker-compose.yml
| "start-server-win": "npm --workspace client run build && SET NODE_ENV=production && node server/index.js", | ||
| "update": "git pull && npm install && npm run start-server" | ||
| "docker:run": "docker-compose up -d", | ||
| "update": "git pull && npm install", |
There was a problem hiding this comment.
Why was npm run start-server removed from the update script?
There was a problem hiding this comment.
I attempted to make npm run update script universal for docker, and a base install.
There was a problem hiding this comment.
So is the recommendation that "manual installs" run npm run update:manual and docker installs run npm run update:docker? I don't see how npm run update would work for both installs (unless I don't understand something about how scripts work)
There was a problem hiding this comment.
Yes, the ideal flow would go like this
Manual user: npm run update:manual
Docker user: npm run update:docker
This would've allowed each user update and start the application the way they would like. Typically the docker image for an app would exist in a place like dockerhub and that would allowed for docker users to not need to use node scripts. but since this is the first iteration of docker, I thought it would be okay for now.
ps. Sorry I should have included this in my pull from the beginning.
There was a problem hiding this comment.
Understandable. I'm quite new to docker, so I'm not very familiar. But I know it's a big request for people interested in this app.
Let's keep update:docker as you have it (or change it to docker:update since the other docker scripts have that naming convention), but let's remove update:manual and just go back to the regular update script the way it was.
README.md
Outdated
| npm run docker:run # Start (build if needed) in background | ||
| npm run docker:logs # Follow logs | ||
| npm run docker:stop # Stop and remove container | ||
| npm run docker:update # git pull then rebuild using latest base images and recreate |
There was a problem hiding this comment.
Should this be npm run update:docker (according to package.json scripts)
README.md
Outdated
|
|
||
| ``` | ||
| cd subarr | ||
| npm run docker:update |
There was a problem hiding this comment.
oops, of course, I've amended the change
|
I have refactored the server part and also provide a docker image for usage. Some bugs are fixed and security issues closed. Take a look https://github.com/dnlrsr/subarr @derekantrican if you are up for the stuff, contact me on discord. Username: dnlrsr |
|
Following along with this PR, so we can get it as a service in the ScaleTail repo. So people can easily host it within their private Tailscale Tailnet network. |
4 participants
Add Docker support to the project, including a Dockerfile, docker-compose configuration, and updated installation instructions in the README. This enhances deployment options and simplifies the setup process for users.