Fix the Typerror by decoding the include paths #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Oh, i've just seen the comment from derekelkins on the pull request for the python 3 version explaining this issue and describing other problems with it. I guess that needs to be fixed before any of this can be merged, so i will close this. I will keep using the python 3 version and report any bugs i find in that pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
"\"-i\"," + ",\"-i\",".join(vim.vars['agdavim_agda_includepathlist'])to create the command for searching in the extra include paths was causingTypeError: sequence item 0: expected str instance, bytes found, becausevim.varsreturns abytesobject. This was preventing agda-vim, the python3 one by 1000000000, from working properly for me (I was getting "Goal not loaded" for everything i tried). I fixed it by mappinglambda x : x.decode()over the result ofvim.vars, and it seems to work fine now. I've read somewhere that this might raise an Exception in the case the bytes aren't proper utf-8 byte sequences, so maybe some sort of handling should be added. This is my first pull request ever, so, sorry if i made any dumb mistakes.