Assembly version compatibility #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Assembly partial name version must be the same as full name version or a previous version. - Assembly partial name version must have the same major version as full name version. This ensures an assembly containing breaking changes (a different major version) isn't chosen.
Additions: - Added support for selecting the maximum element of a collection to select the maximum assembly version - Added the ability to specify whether to match assembly versions exactly Changes: - Changed the assembly path search routine to match assemblies by their exact match first, or fall back to the highest compatible version.
Author
|
This was posted over a month ago without any review @derjabkin, please review. |
| if (source == null) | ||
| throw new ArgumentNullException("source"); | ||
|
|
||
| var sourceItems = source.ToArray(); |
Owner
There was a problem hiding this comment.
Please, do not convert to array. Use Any()
Owner
|
Sorry for the delay. Using most recent version of the found assemblies would only work, if you not using strong names. Can You please check, if the assembly that we are looking for has a public key, then we should use exact matching only. |
Author
|
Thanks. I will apply the recommended changes. |
Author
|
Just a note. Binding redirects can permit even newer stong signed assembly versions to work. So in order to properly handle assembly versioning for strong signed assemblies the binding redirects in app.config also need to be checked if applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for choosing the closest assembly match using semantic versioning assuming that a major version bump is most likely incompatible.