Skip to content

Conversation

@piersquared
Copy link
Collaborator

No description provided.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aiagallery.dbif.ObjSearch does not have a method deleteApp(), unless you added it, and it seems inappropriate. What was the reason for this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said that I need to change removeSelf so that the app is not removed just marked as deleted. I did not get to implement it in objSearch.

Sent from my iPhone

On Dec 5, 2011, at 9:52 AM, Derrell Lipman reply@reply.github.com wrote:

@@ -221,7 +221,7 @@ qx.Mixin.define("aiagallery.dbif.MApps",
searchObj = new aiagallery.dbif.ObjSearch([obj["word"],
obj["appId"],
obj["appField"]]);

  •                    searchObj.removeSelf();
    
  •                    searchObj.deleteApp();
    

aiagallery.dbif.ObjSearch does not have a method deleteApp(), unless you added it, and it seems inappropriate. What was the reason for this change?


Reply to this email directly or view it on GitHub:
https://github.com/derrell/App-Inventor-Gallery/pull/221/files#r269870

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Mon, Dec 5, 2011 at 10:14, piersquared <
reply@reply.github.com

wrote:

@@ -221,7 +221,7 @@ qx.Mixin.define("aiagallery.dbif.MApps",
searchObj = new
aiagallery.dbif.ObjSearch([obj["word"],
obj["appId"],
obj["appField"]]);

  •                    searchObj.removeSelf();
    
  •                    searchObj.deleteApp();
    

You said that I need to change removeSelf so that the app is not removed
just marked as deleted. I did not get to implement it in objSearch.

Oh, ok, I see. That's not something that goes in ObjSearch, however. That's
code that goes right where you inserted the deleteApp() call, to change its
data. (The Obj* classes are all identically organized, with a constructor
and a defer function, but no application-specific member methods.)

Derrell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants