Skip to content

minor changs to delete app #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piersquared wants to merge 3 commits into
base: swedev
Choose a base branch
from
Open

minor changs to delete app #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c94c7f
made some changes for deleted apps
piersquared Dec 4, 2011
0528ad6
Merge branch 'swedev' of git://github.com/derrell/App-Inventor-Galler…
piersquared Dec 4, 2011
ed9c3d2
fixed a grammer error
piersquared Dec 4, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions frontendfsm/aiagallery/source/class/aiagallery/dbif/Constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,17 @@ qx.Class.define("aiagallery.dbif.Constants",
{
Banned : 0,
Pending : 1,
Active : 2
Active : 2,
Deleted : 3
},

/** Reverse mapping of status: values to names */
StatusToName :
[
"Banned",
"Pending",
"Active"
"Active",
"Deleted"
],

/** Mapping of FlagType names to values */
Expand Down
8 changes: 4 additions & 4 deletions frontendfsm/aiagallery/source/class/aiagallery/dbif/MApps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ qx.Mixin.define("aiagallery.dbif.MApps",
});

// Convert from numeric to string status
app.status = [ "Banned", "Pending", "Active" ][app.status];

app.status = [ "Banned", "Pending", "Active","Deleted" ]
[app.status];
},

/**
Expand Down Expand Up @@ -221,7 +221,7 @@ qx.Mixin.define("aiagallery.dbif.MApps",
searchObj = new aiagallery.dbif.ObjSearch([obj["word"],
obj["appId"],
obj["appField"]]);
searchObj.removeSelf();
searchObj.deleteApp();
Copy link
Owner

@derrell derrell Dec 5, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aiagallery.dbif.ObjSearch does not have a method deleteApp(), unless you added it, and it seems inappropriate. What was the reason for this change?

Copy link
Collaborator Author

@piersquared piersquared Dec 5, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said that I need to change removeSelf so that the app is not removed just marked as deleted. I did not get to implement it in objSearch.

Sent from my iPhone

On Dec 5, 2011, at 9:52 AM, Derrell Lipman reply@reply.github.com wrote:

@@ -221,7 +221,7 @@ qx.Mixin.define("aiagallery.dbif.MApps",
searchObj = new aiagallery.dbif.ObjSearch([obj["word"],
obj["appId"],
obj["appField"]]);

  •                    searchObj.removeSelf();

  •                    searchObj.deleteApp();

aiagallery.dbif.ObjSearch does not have a method deleteApp(), unless you added it, and it seems inappropriate. What was the reason for this change?

Reply to this email directly or view it on GitHub:
https://github.com/derrell/App-Inventor-Gallery/pull/221/files#r269870

Copy link
Owner

@derrell derrell Dec 5, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Mon, Dec 5, 2011 at 10:14, piersquared <
reply@reply.github.com

wrote:

@@ -221,7 +221,7 @@ qx.Mixin.define("aiagallery.dbif.MApps",
searchObj = new
aiagallery.dbif.ObjSearch([obj["word"],
obj["appId"],
obj["appField"]]);

  •                    searchObj.removeSelf();

  •                    searchObj.deleteApp();

You said that I need to change removeSelf so that the app is not removed
just marked as deleted. I did not get to implement it in objSearch.

Oh, ok, I see. That's not something that goes in ObjSearch, however. That's
code that goes right where you inserted the deleteApp() call, to change its
data. (The Obj* classes are all identically organized, with a constructor
and a defer function, but no application-specific member methods.)

Derrell

});
}
},
Expand Down
2 changes: 1 addition & 1 deletion frontendfsm/aiagallery/source/class/aiagallery/dbif/ObjAppData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ qx.Class.define("aiagallery.dbif.ObjAppData",
/** Total number of comments on this application */
"numComments" : "Integer",

/** Status of this application (active, pending, banned) */
/** Status of this application (active, pending, banned, deleted) */
"status" : "Integer",

/** Total number of flags on this application */
Expand Down