Fix prayer failure when selecting over an embedded mathquill #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
force-pushed
the
anand/fix-select-over-embedded
branch
from
4ec8ca0 to
697c3ae
Compare
| if (node) { | ||
| // Special case: if we found a node that belongs to a different root than ours, that means we're in a separate, | ||
| // embedded MathQuill instance. In that case, skip to that root's parent and continue. | ||
| const root = findControllerRoot(node); |
Member
There was a problem hiding this comment.
are you worried about run time complexity here? Seems like this itself will do an entire scan up the tree while we are already in a scan up the tree.
Author
There was a problem hiding this comment.
I think it's okay because it will either break the loop or jump up to the container of the embedded MQ instance
test/unit/mouse.test.js
Outdated
| @@ -0,0 +1,77 @@ | |||
| suite.only('mouse', function () { | |||
Member
There was a problem hiding this comment.
If I remember what this means I think we don't want this .only() left in.
mikehaverstock
approved these changes
Oct 1, 2025
Specifically: fixed position for the #mock element, and use measurements to choose our target mouse positions so we know exactly what to expect
mikehaverstock
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a prayer failure when selecting over a separate, embedded MathQuill instance