Skip to content

Conversation

@mikehaverstock
Copy link
Member

@mikehaverstock mikehaverstock commented Dec 2, 2025

There are a couple issues here:

  1. we were collecting the full operatorName in a temp variable but didn't push it to the speechArray if it was the last child of the group. It assumed another child would come afterwards and in that iteration it'd finalize the temp operatorname.
  2. The autoOps dictionary is only accessible from the RootBlock. So all other blocks fail to convert cos to cosine during mathspeak generation.

I have not fixed (2) and don't plan on fixing it. Fixing (1) is enough for my purposes.

@mikehaverstock mikehaverstock requested review from jared-hughes and sclower and removed request for sclower December 2, 2025 16:00
@mikehaverstock mikehaverstock merged commit 9e9ba41 into main Dec 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants