PoS Spending Limits UI #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2024
Merged
Closed
Closed
Closed
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lazynina
force-pushed
the
pos-spending-limits
branch
from
ad3d82e to
e953669
Compare
lazynina
force-pushed
the
pos-spending-limits
branch
2 times, most recently
from
e903b84 to
62c3d00
Compare
lazynina
force-pushed
the
pos-spending-limits
branch
from
62c3d00 to
76dbdf3
Compare
lazynina
force-pushed
the
pos-spending-limits
branch
from
76dbdf3 to
1e4c26b
Compare
| value: number = 0; | ||
| } | ||
|
|
||
| // TODO: does this need to be updated? Where is it really used? |
Member
There was a problem hiding this comment.
Isn't this used to serialize/deserialize the metadata of a txn in the FE? I think it doesn't need to be updated because we're recycling the same struct for lockups right?
Member
Author
There was a problem hiding this comment.
It's not actually used anywhere. It's referenced, but these references are unused.
| case LockupLimitOperationString.COIN_LOCKUP: | ||
| return 'Lockup'; | ||
| case LockupLimitOperationString.COIN_LOCKUP_TRANSFER: | ||
| return 'Transfer'; |
Member
There was a problem hiding this comment.
Just test to make sure these strings look good, make sense, and are sufficiently descriptive wherever they appear.
lazynina
added a commit
that referenced
this pull request
Apr 30, 2024
lazynina
added a commit
that referenced
this pull request
Jun 17, 2024
* Add newline to make graphite happy * Lockups (#299) * Add transcoder for Register as validator transaction. Add support for approve component for this txn type * Add transcoder for Unregister as validator txn type. Add support for approve component for this new txn type * Add transcoder for stake transaction metadata. Add support for approve component for this new txn type. * Add transcoder for Unstake txn type. Add support for approve component for this new txn type. * Add transcoder for Unlock stake txn type. Add support for approve UI for this new txn type * Add transcoder for Unjail Validator txn type. Add approve UI support for this new txn type. * Add support for coin lockup txn types --------- Co-authored-by: Lazy Nina <> * PoS Spending Limits UI (#298) * Update computation of expiration block height (#300) * PoS Spending Limits UI * Update computation of expiration block height --------- Co-authored-by: Lazy Nina <> Co-authored-by: Jon Pollock <135658176+poolcoke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.