Enhance Color Contrast for Improved Accessibility #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement REST API endpoints for auctions app including: - User authentication with JWT - Listings with bidding functionality - Watchlist management - Comments system - Custom permissions for resource access control - Advanced filtering for listings, bids and comments
add websocket consumer, notification service, and celery tasks for handling bid, outbid, and auction ending notifications
…dark mode support - Implement responsive CSS for profile, dashboard and search pages - Add comprehensive dark mode support for all new components - Improve color contrast and accessibility across all themes - Add animations and hover effects for better user experience
- Implement alert auto-dismiss functionality with manual close option - Add dashboard charts for category distribution and monthly trends - Create advanced search with autocomplete, filters and view toggle
- Create new list_item.html component for auction listings with responsive design - Remove inline z-index from alert container as it's now handled by CSS - Update watchlist URL in footer to use named route 'my_watchlist'
…rity Simplify watchlist button logic by separating add/remove actions into distinct forms
- Add search page link and stylesheet - Replace watchlist URL with my_watchlist - Convert user info to dropdown menu with profile and dashboard links - Add notifications link with badge - Include search.js for search page
Implement a comprehensive notification system including: - WebSocket connection for real-time updates - Notification list display with read/unread status - Toast notifications for new alerts - Sound notification option - Mark as read functionality
Add a comprehensive dashboard template for displaying auction metrics and KPIs
Add two new template filters: - is_in_watchlist to check if a listing is in user's watchlist - to_json to convert Python data to JSON with Decimal type handling
Add default_auto_field configuration and import signals module in ready method to ensure proper initialization
Remove redundant title uniqueness check in ListingForm since it's already handled at the model level. Also remove debug print statement in BidForm's clean_amount method.
Implement RateLimitMiddleware to add rate limiting headers to responses Add SecurityMiddleware with request size validation, suspicious user agent detection, and security headers
- Add Notification model with type, title, message and read status - Make listing title unique and bid amount required - Add timestamps to Bid and Watchlist models - Improve string representations for models
…size Implement CustomPageNumberPagination to allow clients to specify page size via URL parameters with sensible defaults and limits
Add new endpoints for my-watchlist, search, notifications, profile, and dashboard. Remove trailing slashes from existing URLs for consistency.
Implement custom rate limiting decorator to protect against abuse Add rate limiting to critical endpoints like login, bidding and listing creation Include configuration via settings with different limits for anonymous and authenticated users
Integrate Channels to handle websocket connections with authentication middleware
Add optimized test configuration including in-memory database, disabled logging, and faster password hashing to improve test performance
- Add REST framework, JWT, and API documentation support - Implement security middleware and production security settings - Configure channels for async support and Redis for channel layers - Add rate limiting and caching configurations - Set up CORS for frontend integration
Add a dedicated test settings file with configurations optimized for testing: - Use in-memory SQLite database - Disable migrations for faster tests - Configure faster password hashing - Disable logging and caching - Set up local email backend - Disable rate limiting
- Add versioned API endpoints under /api/v1/ - Include API documentation using drf-spectacular (schema, Swagger UI, Redoc) - Enable static files serving in DEBUG mode for media and static files
Add tests for various components including: - Rate limiting functionality - Security middleware - Notifications system - Advanced search features - REST API endpoints - Test utilities and fixtures Includes unit tests, integration tests, and performance tests covering core platform functionality. Tests verify authentication, authorization, rate limiting, search, bidding, and API endpoints. Uses pytest and Django's test framework with factories for test data generation.
Add create_test_data.py to generate sample users, listings and bids for testing the auctions application
Add a mock module to prevent ImportError during test execution
Add a new Python script to automate code formatting with Black and linting with flake8. The script provides options to run either formatting, linting, or both operations.
…mance, including navigation component and additional CSS files
… class assignment in auction forms
…g chart colors, metrics, export options, predictive analysis, and alerts
…alytics, listings management, user management, and data export functionalities
…rics, time series analysis, user behavior, bid analysis, and market trends visualization
… analytics, including user engagement scoring, market volatility calculation, and anomaly detection
…rors, including debug information for development and user-friendly pages for production
…500 errors, enhancing user experience with personalized error views
…existing paths for consistency, enhancing the structure and accessibility of the application
…d import_export apps, implementing custom error handling settings, and refining static file management for development
…dlers, static file management for development, and refine admin panel routing for improved application structure
…g project cleanliness and build management
… for analytics, alerts, export options, caching, logging, and chart colors
…ced data analysis and visualization capabilities
This commit addresses the issue of scattered and repetitive CSS by establishing a single source of truth for design tokens and refactoring all stylesheets to use it. Key changes include: - Consolidated all CSS variables into `auctions/static/css/variables.css`. - Removed duplicate and conflicting variable definitions from `auctions/static/css/auctions/styles.css` and other stylesheets. - Refactored all page-specific and component-specific CSS files to use the unified variables from `variables.css`. - Extracted all inline `<style>` blocks from HTML templates (primarily in the admin section) into a new `auctions/static/css/admin.css` file. - Removed inline `style="..."` attributes from HTML templates and replaced them with utility classes. - Extracted inline JavaScript from `auctions/templates/auctions/admin/base.html` into a new `auctions/static/js/admin.js` file. This results in a cleaner, more maintainable, and consistent CSS architecture that aligns with best practices.
…tion style: format code with Black and Ruff Formatter
The dark/light mode theme toggle was not working because the `variables.css` file, which contains the color definitions for both themes, was not being loaded in the main `layout.html` template. This commit adds the necessary `<link>` tag to `layout.html`, ensuring that the CSS variables are available and allowing the theme to change correctly when toggled by the existing JavaScript.
Fix: Link variables.css to enable theme switching
This commit modifies the `variables.css` file to ensure that CSS variables are correctly applied for the light theme. The changes include adding a selector for `[data-theme="light"]` to the root variables, allowing for proper theme switching functionality.
This commit eliminates the inline JavaScript from the theme toggle button in the navigation component, improving code maintainability and separation of concerns.
This commit refactors the theme initialization process to occur only after the DOM is fully loaded, enhancing performance. It also adds default behavior for theme application and includes debug logging for theme changes, improving traceability during development.
This commit adjusts the color variables for both light and dark themes to improve text readability and ensure compliance with WCAG AA accessibility standards. The following changes have been made to `auctions/static/css/variables.css`: - In the light theme, `--text-tertiary` and `--text-muted` colors have been darkened to increase their contrast against light backgrounds. - In the dark theme, `--text-tertiary` and `--text-muted` colors have been lightened to ensure they stand out against dark backgrounds. These changes result in a better user experience, especially for users with visual impairments.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the color contrast for both light and dark themes to meet WCAG AA accessibility standards. The changes involve adjusting the CSS variables for tertiary and muted text colors to ensure a minimum contrast ratio of 4.5:1.
PR created automatically by Jules for task 1509716728605446830