fix: improve release workflow with proper npm publishing#6
Merged
Conversation
f6dcef9 to
1432d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: improve release workflow with proper npm publishing
This PR improves the CI/CD workflow to correctly handle the npm publishing process after release PR merges.
Changes
Split the release job into two separate jobs:
create-release: Handles creating the release PR with release-pleasepublish-npm: Only runs after a release is actually createdFixed the conditional logic to only publish when release-please creates a release
releases_createdoutput parameter from release-pleaseUses the built-in
GITHUB_TOKENfor authenticationBenefits
This approach ensures that:
This gives proper manual control over the release process while automating version bumping and changelog generation.