feat: adding env var for "dirname" to mirror the logic in electron-builder #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic already uses env var
ELECTRON_BUILDER_BINARIES_MIRRORapp-builder/pkg/download/tool.go
Lines 61 to 81 in 580c34f
But it does not allow customization of the dir (both being the
idof the asset)app-builder/pkg/download/tool.go
Line 63 in 580c34f
This implementation now will properly mirror the (duplicated) logic in electron-builder for app-builder-bin downloading
https://github.com/electron-userland/electron-builder/blob/3d65267a6c53ca824f70e5b0f5d8f4ba8be38237/packages/app-builder-lib/src/binDownload.ts#L25-L38