fix(ui-library): radio component fixes

[ashk1996]

closes #916 closes #479 closes #824 closes #764 closes #1073 closes #1141 closes #766

[thrbnhrtmnn]

Hey @ashk1996 ,
here are my findings:

Radio - remove error message #916

• When I set hasError=true, an error message is shown. This should not be there.

Radio - add missing events #479

• In the ticket an onChange event should have been added instead of the onClick event.

Radio - fix value prop #824

• no remarks here, all looks good

Radio - fix size of input control and icon and add optional max width #764

• I think this one we should have a quick look together at. I am not sure how I can test this, as the tokens have the same value in each size-variant.

I will continue testing this one later. I only got to check half of the tickets done by this PR.

[thrbnhrtmnn]

Hey @ashk1996 ,

I finished looking at the remaining tickets. All looks fixed here, except I didn't know what exactly needed to be changed with #1072 for the radio component. Therefor I can not review the ACs of this ticket. I would leave this one up to @ChristianHoffmannS2 .

Unfortunately I did not see any changes to the previous comments. Please have a look again at these and let me know once I can review them again. Or maybe did you just forget to push the last changes?

[thrbnhrtmnn]

Hey @ashk1996 ,
as just reviewed together there is just one open point:

Radio - remove error message #916

• You removed the error message, but overlooked one spacing, which comes from the form-caption-group the error message was part of:
  
  
• The form caption group only should be part of the component, if we also show a caption. In this case for the radio this should only happen when hasHint is true.

[thrbnhrtmnn]

Hey @ChristianHoffmannS2 , I found one issue. When hasError=true, and checked=true, the control is displayed in the wrong color:

This also happens in dark mode: