add service uuids to notifications #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwandor
reviewed
Nov 3, 2025
src/bluez/peripheral.rs
Outdated
| let uuid = find_characteristic_by_id(&services, id)?.uuid; | ||
| Some(ValueNotification { uuid, value }) | ||
| let info = find_characteristic_by_id(&services, id.clone())?; | ||
| let service = services.iter().find(|(_, s)| s.info.id == id.service())?.0; |
Collaborator
There was a problem hiding this comment.
Rather than looping through services a second time, how about making find_characteristic_by_id return the ServiceInfo as well as the characteristic?
Author
There was a problem hiding this comment.
I changed it to return a tuple with characteristic and service info.
qwandor
approved these changes
Nov 4, 2025
Author
|
Are there any plans on when you will do the next release? Or do you know any other way I could publish an update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to support multiple characteristics with the same UUID in different services in tauri-plugin-blec.
In order to support this for subscribes, the ValueNotification has to specifiy what service caused it.
I added the values for all the integrations except Android, because I don't really know how to work with the jni code.
I can look at the android version, but I would prefer if someone with more experience in this area could do that.
The problem is I need a new release of this library with the added fields in order to release my crate with the new dependency.
If i checked correctly, there is no way to publish to crates.io with my github fork as dependency