#1602: Being offline can block ide startup #1671
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #1602: Being offline can block IDE startup when a tool update is available but not cached.
Changes
Core Fix
doDownload()to check if download is already cached before throwingCliOfflineExceptionin offline modeperformToolInstallation()to returnVersionIdentifierindicating which version was actually installedSupporting Changes
performToolInstallation()signatureTests
Added comprehensive test coverage in InstallCommandletTest.java:
testInstallCommandletOfflineWithCachedDownload: Fresh install with cached download succeedstestInstallCommandletOfflineWithoutCachedDownload: Fresh install without cache fails appropriatelytestInstallCommandletOfflineUpdateWithoutCachedDownload: Update scenario keeps old version when new version not cachedDocumentation
Testing
All offline scenario tests pass successfully:
Checklist
#1602: Being offline can block ide startupRelated Issue
Closes #1602