#1667: fix ide env triggering unintended tool installations #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override isInstalled() in PackageManagerBasedLocalToolCommandlet to use file existence check instead of version computation which was triggering package manager execution and causing unintended installations. - Add isInstalled() override using SystemPath.findBinary() for platform-specific binary resolution - Update JavaDoc for computeInstalledVersion() with warning about not triggering installations - Remove redundant isInstalled() override from NodeBasedCommandlet - Add test in IdeasyTest to verify running 'ide' without arguments doesn't trigger installations - Update CHANGELOG.adoc
maybeec
added
bugfix
Collaborator
Pull Request Test Coverage Report for Build 20817627478Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1667 - Running
idewithout arguments was triggering unexpected downloads and installations.Root Cause
The issue occurred because
EnvironmentCommandlet.setEnvironmentVariablesInLocalTools()iterates through all local tools and callsisInstalled()on each. For package-manager-based tools (pip, npm, yarn, etc.), the inheritedisInstalled()implementation was callinggetInstalledVersion()→computeInstalledVersion()→runPackageManager()withoutskipInstallation=true, which triggered installation cascades.See detailed analysis in issue comment.
Solution
Override
isInstalled()inPackageManagerBasedLocalToolCommandletto use file existence check withSystemPath.findBinary()instead of version computation. This prevents triggering the package manager during environment setup while still correctly detecting installed tools.Changes
isInstalled()inPackageManagerBasedLocalToolCommandletusing platform-specific binary resolution@implNotewarning tocomputeInstalledVersion()JavaDocisInstalled()fromNodeBasedCommandlet(now inherited)testRunWithoutArgumentsDoesNotTriggerInstallation()inIdeasyTestTesting
idewithout arguments doesn't create new tool directoriesChecklist
#«issue-id»: «describe your change»