Skip to content

Conversation

@hohwille
Copy link
Member

@hohwille hohwille commented Jan 12, 2026

This PR contains a cleanup refactoring

Implemented changes:

  • Refactor package structure for Separation of Concerns
  • Now things that logically belong together are in the same package regarding tool related stuff.
  • E.g. MvnArtifact and MvnRepository are together with Mvn commandlet inside the mvn sub-package.
  • The same for npm, pip, etc.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@hohwille hohwille added this to the release:2026.01.001 milestone Jan 12, 2026
@hohwille hohwille self-assigned this Jan 12, 2026
@hohwille hohwille added commandlet ide sub-command internal Nothing to be added to CHANGELOG, only internal story labels Jan 12, 2026
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Jan 12, 2026
@hohwille hohwille moved this from 🆕 New to 👀 In review in IDEasy board Jan 12, 2026
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 20930596111

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 69.914%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/repository/ArtifactToolRepository.java 1 92.31%
com/devonfw/tools/ide/tool/mvn/MvnArtifact.java 3 88.0%
Totals Coverage Status
Change from base Build 20848427570: 0.01%
Covered Lines: 10193
Relevant Lines: 14003

💛 - Coveralls

@hohwille hohwille merged commit fcadaae into devonfw:main Jan 12, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDEasy board Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commandlet ide sub-command internal Nothing to be added to CHANGELOG, only internal story

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants