Improve rule KeepLatestNVersionImagesByProperty#163
Merged
allburov merged 1 commit intodevopshq:masterfrom Mar 20, 2025
Merged
Conversation
Allow more custom version when used with corresponding custom regex e.g. - version with prefix (uat-1.2.3) - any other version structure if there is at least an int for major, minor and patch in this order (see added tests)
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Docker cleanup rules by allowing custom version formats to be parsed and filtered according to flexible regex patterns. Key changes include:
- Addition of new tests in tests/test_rules_docker.py for versions with a prefix and custom version patterns.
- Modification of the get_version method in artifactory_cleanup/rules/docker.py to use capturing groups from the regex.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_rules_docker.py | Added tests to verify the new custom regex version parsing behavior. |
| artifactory_cleanup/rules/docker.py | Updated get_version to extract version parts using regex capturing groups. |
Comments suppressed due to low confidence (1)
artifactory_cleanup/rules/docker.py:266
- This change assumes that the provided custom_regexp will always include capturing groups. Consider adding a check to confirm that match.groups() is not empty, or update the documentation to clearly state that a capturing group is required in the regex.
version_str = '.'.join(map(str, match.groups()))
Member
|
Thank you! We'll release a new version with the fix let's say 8 Apr! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow more custom version when used with corresponding custom regex
e.g.