Fix PropertyEq for multiple properties and improve query performance#171
Merged
allburov merged 1 commit intodevopshq:masterfrom Jan 26, 2026
Merged
Conversation
Contributor
Author
|
@allburov Can you have a look at this PR please? |
Contributor
Author
|
@allburov Thanks for the fast merge! Can you also create a new release? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PropertyEqrule when artifacts have multiple propertiesMotivation
The current
PropertyEqimplementation checks the property key and value in separate conditions. This can produce false positives when an artifact has multiple properties, because the key and value may match different properties instead of the same one.By using Artifactory’s @ property syntax, the rule ensures the key and value belong to the same property and generates a single condition, improving correctness and performance.
Example
Rule:
Current SQL (incorrect for multiple properties):
New SQL (correct and faster):