BuildManager: Correctly handle builds with quoting in their name#477
Merged
allburov merged 2 commits intodevopshq:masterfrom Mar 18, 2025
Merged
BuildManager: Correctly handle builds with quoting in their name#477allburov merged 2 commits intodevopshq:masterfrom
allburov merged 2 commits intodevopshq:masterfrom
Conversation
quote is not officially part of requests.utils API, it is just imported from requests.compat which imports it from urllib.parse. So just use it directly. Much less confusing. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Since we quote the build names when using them in a URL we need to make sure they are unquoted to begin with to avoid double quoting. Happens e.g. with builds containing spaces. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
allburov
approved these changes
Mar 18, 2025
Member
|
Danke! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we quote the build names when using them in
a URL we need to make sure they are unquoted to
begin with to avoid double quoting.
Happens e.g. with builds containing spaces.