Skip to content

Fix compile error on Linux and update Makefile#28

Open
kinggizzardandtheinstallationwizard wants to merge 2 commits intodevshane:masterfrom
kinggizzardandtheinstallationwizard:pullme
Open

Fix compile error on Linux and update Makefile#28
kinggizzardandtheinstallationwizard wants to merge 2 commits intodevshane:masterfrom
kinggizzardandtheinstallationwizard:pullme

Conversation

@kinggizzardandtheinstallationwizard
Copy link

@kinggizzardandtheinstallationwizard kinggizzardandtheinstallationwizard commented Jan 27, 2026

There is a fatal error in local.c that occurs in Linux but not Darwin/MacOS (unsure if other platforms are affected) if unistd.h is not included.

I also went ahead and moved all of the parts of the Makefile that vary per end-user to a new config.mk file. Additionally I bumped terminfo to the top of the list over termcap because that has been the more common option for a very long time now.

@justwheel
Copy link
Collaborator

@jamesjer opened a downstream Fedora Linux RPM pull request to the package spec for zork in Fedora. I am hoping that we can work together to upstream those changes, including the use of terminfo instead of termcap, as part of a series of subsequent PRs to keep zork compiling for Linux users for generations to come.

I have not taken a close look to see how this PR differs from @jamesjer's patches yet. He also did some modernization efforts to C23.

@kinggizzardandtheinstallationwizard
Copy link
Author

kinggizzardandtheinstallationwizard commented Feb 17, 2026

I skimmed over it a little. The modernization work looks wonderful, a lot of much-needed changes. The changes in my PR do not touch much code at all, I just added a single include and rearranged the Makefile a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments