Skip to content

fix: use fetchMe() for proper permission check in discord.js v14+ #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snakkeyy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use fetchMe() for proper permission check in discord.js v14+ #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// noinspection ExceptionCaughtLocallyJS,JSUnusedGlobalSymbols

const axios = require('axios');
const {PermissionsBitField} = require('discord.js');
const { PermissionsBitField } = require('discord.js');

class VibeSync {
/**
Expand All @@ -15,7 +15,7 @@ class VibeSync {
this.Client = Client;
this.api = axios.create({
baseURL: options.baseURL || 'https://discord.com/api/v10',
headers: {Authorization: `Bot ${Client.token}`},
headers: { Authorization: `Bot ${Client.token}` },
timeout: options.timeout || 7000,
});
}
Expand All @@ -26,11 +26,20 @@ class VibeSync {
* @param {String} channelId
*/
async _checkPermissions(channelId) {
let channel = this.Client.channels.cache.get(channelId) || await this.Client.channels.fetch(channelId).catch(() => null);
let channel =
this.Client.channels.cache.get(channelId) ||
await this.Client.channels.fetch(channelId).catch(() => null);

if (!channel) throw new Error(`Channel ${channelId} not found or could not be fetched.`);
if (channel.type !== 2) throw new Error(`Channel ${channelId} is not a voice channel.`);
const permissions = channel.permissionsFor(channel.guild.members.me);
if (!permissions || !permissions.has(PermissionsBitField.Flags.ManageChannels)) throw new Error('Missing MANAGE_CHANNELS permission.');

const me = await channel.guild.members.fetchMe().catch(() => null);
if (!me) throw new Error('Failed to fetch bot member.');

const permissions = channel.permissionsFor(me);
if (!permissions || !permissions.has(PermissionsBitField.Flags.ManageChannels)) {
throw new Error('Missing MANAGE_CHANNELS permission.');
}
}

/**
Expand All @@ -42,12 +51,18 @@ class VibeSync {
async setVoiceStatus(channelId, status = '') {
await this._checkPermissions(channelId);
try {
const response = await this.api.put(`/channels/${channelId}/voice-status`, {status});
const response = await this.api.put(`/channels/${channelId}/voice-status`, { status });
if (![200, 204].includes(response.status)) throw new Error(`Unexpected status code: ${response.status}`);
return {success: true};
return { success: true };
} catch (error) {
console.error('API Fehler:', error);
throw new Error(error.response?.data?.message ? `API Error: ${error.response.data.message}` : error.request ? 'No response from API.' : `Request Error: ${error.message}`);
throw new Error(
error.response?.data?.message
? `API Error: ${error.response.data.message}`
: error.request
? 'No response from API.'
: `Request Error: ${error.message}`
);
}
}

Expand All @@ -61,4 +76,4 @@ class VibeSync {
}
}

module.exports = {VibeSync};
module.exports = { VibeSync };