docs(Angular): fix incorrect db reference in populate() example
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: use `this` instead of `db` inside AppDB.populate() method The populate() method was referencing the module-level `db` variable before it was declared. While this works due to JavaScript's execution timing (the callback runs after instantiation), it's technically incorrect and could cause unexpected behavior with multiple instances. Changed `db.todoLists` → `this.todoLists` and `db.todoItems` → `this.todoItems`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: use
thisinstead ofdbinside AppDB.populate() methodThe populate() method was referencing the module-level
dbvariable before it was declared. While this works due to JavaScript's execution timing (the callback runs after instantiation), it's technically incorrect and could cause unexpected behavior with multiple instances.Changed
db.todoLists→this.todoListsanddb.todoItems→this.todoItems