feat: remove artifact functions #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cha0sg0d
force-pushed
the
cha0s/getter-facet-room
branch
from
16b435b to
e0442a0
Compare
|
why are you putting these getters here instead of getterfacet2? we are going to need to add more getters as we continue to build, where do you see those functions going? |
Author
Ideally getters are specific to their functionality. Like the DFArtifact facet should handle all thing artifacts. So we can start to break up the getters into their component pieces. If we have new getters that don't relate to Artifacts or Spaceships, they can go in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.