Fix Contact Management and Error Handling #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only trigger Contact_Change events for new contacts, not self - Remove duplicate contact notifications - Add error handling to contact loading with graceful fallback - Change load() return type from Map to Contact array - Remove unused get() method
chriselsen
added
connections
- Add back get() method to AtlasTeam class for contact lookup by UID - Fixes TypeScript error in PropertyCreator.vue component
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the contact management system by fixing notification issues and adding better error handling.
Changes Made:
Contact_Changefor new contacts, excluding self to prevent duplicate notificationsload()return type fromMap<string, Contact>toContact[]for better consistencyget()methodBug Fixes:
Fixes #838