Fix incorrect usage of phpCAS on PT renewal#12
Open
mabes wants to merge 1 commit intodfwarden:masterfrom
Open
Conversation
Using retrievePT without updating the phpCAS client from session info will result in an incorrect call to the CAS server : Error while retrieving new PT: PT retrieving failed (code=`INVALID_REQUEST', message=`'pgt' and 'targetService' parameters are both required') This only happens in cases where the PT becomes invalid without expiring, for instance if the credential cache does not manage multiple credentials, or if it expires for any reason other than timing out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using retrievePT without updating the phpCAS client from session info
will result in an incorrect call to the CAS server :
Error while retrieving new PT: PT retrieving failed
(code=
INVALID_REQUEST', message='pgt' and 'targetService' parameters are bothrequired')
This only happens in cases where the PT becomes invalid without
expiring, for instance if the credential cache does not manage multiple
credentials, or if it expires for any reason other than timing out.
This particular cas was not handled by the previous code.