-
Notifications
You must be signed in to change notification settings - Fork 138
Fixing row and column tracking when there are blank cells #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you! |
| */ | ||
| private String parseSharedFormula(Integer dCol, Integer dRow, String baseFormula) { | ||
| String res = ""; | ||
| StringBuilder res = new StringBuilder(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| } | ||
|
|
||
| Cell cell = parseCell(trackedColIndex++); | ||
| Cell cell = parseCell(trackedColIndex++, rowIndex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we have both trackedRowIndex field and parameter.
Shouldn't this.trackedRowIndex just be increated in this loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's an option. I added the rowIndex parameter to match the existing colIndex parameter instead of getting one piece of info from the parameter and the other from the attribute
I added a new test case for the RowSpliterator class. I could not create a test that processes the spreadsheet where I found the issue because it contains customer sensitive data, and I didn't manage to create another one - in all my attempts all cells had explicit addresses in the xml content. |
8da7b5b to
e655aba
Compare
e655aba to
88f9f1e
Compare
88f9f1e to
dc80b07
Compare
Fixed cell row and column index tracking when there are blank cells at the beginning of the row, like:
The A2 cells is blank the the lib loses track of the indexes.