Open
Conversation
zeozeozeo
reviewed
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As i am currently writing a file plugin for a my music server, i needed a library which reads metadata including the duration of a file as fast as possible.
All well established cgo binding based solutions (libvlc, taglib...) I've tested were at least 25% slower than this library.
So i decided to add duration support for this library.
This PR does change the public API of this library in several places, which i guess is not desired. As you have mentioned here #106 (review) you have a solution in mind for this problem. So i thought it might be smarter to wait for you to make a suggestion here after you saw my code and I'll adjust the PR accordingly. I think it wont be a lot of work as the code for the duration reading is already written now.
Technical notes: