Skip to content

Conversation

@Sanketmundada
Copy link

@Sanketmundada
Copy link
Author

@lucifercr07 could you please review this

@Sanketmundada
Copy link
Author

@lucifercr07 can you give approval for running workflow, because I think as we have not yet deployed api, E2E tests wont work, as we wont have running instance of api and ui on localhost in the pipeline

Your thoughts on this?

@Sanketmundada
Copy link
Author

@lucifercr07 It seems pipeline is failing as we don't have server and client up and running

@lucifercr07
Copy link
Contributor

@Sanketmundada I don't see any workflow getting triggered, please have a look.

@Sanketmundada
Copy link
Author

Sanketmundada commented Oct 9, 2024

@lucifercr07 Will look into it, meanwhile could you please tell me whether we really should keep test:e2e in workflow or not, as it requires both ui and api to be up.

If we have to keep then I'm wondering how we can do that?

@lucifercr07 lucifercr07 requested a review from KaviiSuri October 15, 2024 17:27
@lucifercr07
Copy link
Contributor

@KaviiSuri please add your inputs.

@KaviiSuri
Copy link
Contributor

IMO, we can do 2 things:

  1. Have a dev/staging instance running that we point to for backend
  2. Run the docker container in the tests them selves

Id prefer the 2nd one since we only use resources when we need them.

Regarding running them in workflows, i would rather not. I think we should make it triggered through the actions panel on github, and can even setup a daily test run using cron schedules

/* Opt out of parallel tests on CI. */
workers: process.env.CI ? 1 : undefined,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: 'html',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also use GitHub reporter here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants