Skip to content

Conversation

@tautschnig
Copy link
Collaborator

We do not need a one-test-per-directory set-up anymore as nowadays test.pl can safely use multiple tests in a single directory. This avoid indefinitely growing the number of directories, making navigation much harder.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copilot AI review requested due to automatic review settings December 23, 2025 09:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates test files in the regression/cbmc-library directory by removing numeric suffixes and combining tests that were previously separated into individual directories. The changes update test files to properly test builtin infinity functions instead of unrelated library functions.

  • Removes the one-test-per-directory requirement to simplify navigation
  • Updates test files to call the correct builtin functions they're intended to test
  • Corrects include headers to match the actual function being tested

Reviewed changes

Copilot reviewed 3 out of 993 changed files in this pull request and generated no comments.

File Description
regression/cbmc-library/__builtin_infl/main.c Updates test to call __builtin_infl() instead of memset() and includes math.h instead of string.h
regression/cbmc-library/__builtin_inff/main.c Updates test to call __builtin_inff() instead of malloc() and includes math.h instead of stdlib.h
regression/cbmc-library/__builtin_inf/main.c Updates test to call __builtin_inf() instead of htonl() and includes math.h instead of inet.h

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tautschnig tautschnig force-pushed the cbmc-library-no-suffix branch 3 times, most recently from bebb8bb to 498e1fb Compare December 23, 2025 09:56
…brary

We do not need a one-test-per-directory set-up anymore as nowadays
test.pl can safely use multiple tests in a single directory. This
avoid indefinitely growing the number of directories, making navigation
much harder.
@tautschnig tautschnig force-pushed the cbmc-library-no-suffix branch from 498e1fb to 90f278f Compare December 23, 2025 10:05
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.00%. Comparing base (945c1e0) to head (90f278f).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8815   +/-   ##
========================================
  Coverage    80.00%   80.00%           
========================================
  Files         1700     1700           
  Lines       188257   188257           
  Branches        73       73           
========================================
  Hits        150615   150615           
  Misses       37642    37642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig merged commit e01fcdb into diffblue:develop Dec 23, 2025
40 of 41 checks passed
@tautschnig tautschnig deleted the cbmc-library-no-suffix branch December 23, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants