Issue #2634: Add StreamRulesRecipes

[Pankraz76]

Issue #2634: Add StreamRulesRecipes

enabler for:

• PoC: Add rewrite support for errorprone.refasterrules #2576
• https://error-prone.picnic.tech/refasterrules/StreamRules/
• https://docs.openrewrite.org/recipes/tech/picnic/errorprone/refasterrules/streamrulesrecipes

related:

• Apply StreamRulesRecipes apache/maven#11159
• Issue #17487: Add StreamRulesRecipes checkstyle/checkstyle#17782

[Pankraz76]

Kindly request some feedback on this.

Thanks for consideration.

[jochenberger]

I hope we can get this merged soon. It might help to eventually replace the fragile Eclipse-based formatters.

[Pankraz76]

nice yes in check we have integrated it already:

• Issue #17487: Add StreamRulesRecipes checkstyle/checkstyle#17782

[nedtwigg]

I checked this out and it looks great. Except I get lots of errors along these lines:

Scanning sources in project :testlib
Using active styles []
Unable to resolve classpath for sourceSet :testlib:main
org.gradle.api.internal.artifacts.configurations.DefaultConfiguration$IllegalResolutionException: Resolution of the configuration ':testlib:runtimeClasspath' was attempted without an exclusive lock. This is unsafe and not allowed.

2 problems were found storing the configuration cache.
- Task `:rewriteDryRun` of type `org.openrewrite.gradle.RewriteDryRunTask`: cannot serialize object of type 'org.gradle.api.internal.project.DefaultProject', a subtype of 'org.gradle.api.Project', as these are not supported with the configuration cache.
  See https://docs.gradle.org/9.0.0/userguide/configuration_cache_requirements.html#config_cache:requirements:disallowed_types
- Task `:rewriteDryRun` of type `org.openrewrite.gradle.RewriteDryRunTask`: invocation of 'Task.project' at execution time is unsupported with the configuration cache.
  See https://docs.gradle.org/9.0.0/userguide/configuration_cache_requirements.html#config_cache:requirements:use_project_during_execution

My two requirements for merging this are:

• a regular build should not have warnings
• don't add a new CI task, just add it into sanityCheck right after these lines

• spotless/.github/workflows/ci.yml

  Lines 32 to 35 in 6991270

  	- name: spotlessCheck
  	run: ./gradlew spotlessCheck
  	- name: assemble testClasses
  	run: ./gradlew assemble testClasses

[Pankraz76]

Changes have been made:

Changes have been made to lib/src/main/java/com/diffplug/spotless/npm/NodeServerLayout.java by:
    tech.picnic.errorprone.refasterrules.StreamRulesRecipes
        tech.picnic.errorprone.refasterrules.StreamRulesRecipes$StreamFindAnyIsPresentRecipe
Changes have been made to lib/src/main/java/com/diffplug/spotless/npm/FileFinder.java by:
    tech.picnic.errorprone.refasterrules.StreamRulesRecipes
        tech.picnic.errorprone.refasterrules.StreamRulesRecipes$StreamMapFirstRecipe
Changes have been made to plugin-maven/src/main/java/com/diffplug/spotless/maven/AbstractSpotlessMojo.java by:
    tech.picnic.errorprone.refasterrules.StreamRulesRecipes
        tech.picnic.errorprone.refasterrules.StreamRulesRecipes$StreamOfNullableRecipe

[Pankraz76]

even "faster" than spot:

[nedtwigg]

• conflicts with [openrewrite] initial merge and UpgradeToJava17 #2636, since that one is bigger I'm gonna close this one and merge the other
• please label all these openrewrite PRs as "[openrewrite]"
• please limit to one open at a time please
• these are useful, thank you for contributing them, but they change a lot of code so it is somewhat time-consuming for me to review
• i will try to merge them in a timely manner, but i don't look at Spotless every day so there will be some gaps