[fix] Configuration cache for groovy#2797
Merged
nedtwigg merged 4 commits intodiffplug:mainfrom Jan 21, 2026
Merged
Conversation
Goooler
reviewed
Jan 1, 2026
| termsOfUseAgree = "yes" | ||
| publishing { | ||
| onlyIf { providers.environmentVariable('CI').present } | ||
| onlyIf { getenv('CI') != null } |
Contributor
Author
There was a problem hiding this comment.
yes, it just causes a warning for configuration cache. Nothing breaks, but I think code looks cleaner and it doesn't cause a warning
| if (!getProject().getPlugins().hasPlugin(GroovyBasePlugin.class)) { | ||
| throw new GradleException(message); | ||
| } | ||
| final boolean excludeJavaValue = excludeJava; |
Member
There was a problem hiding this comment.
This might be related, but needs to add a test for verifiing it.
Contributor
Author
There was a problem hiding this comment.
I was able to confirm locally that it fixes the issue, but wasn't able to write a working test (it just passed even though it failed in project). If it is really needed I will try to make it work a bit later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this mr is parallel configuration cache issue I encountered in fabric-loom plugin. It can be reproduced by adding
in gradle.properties
I am definitely not a plugin developer, I tried to write a unit test for this to reproduce, but wasn't able to (test passed even though it fails in fabric-loom plugin)
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)