Closed
Conversation
Pankraz76
commented
Jan 10, 2026
| - name: Rewrite ♻️ | ||
| run: ./gradlew rewriteDryRun | ||
| - name: assemble testClasses | ||
| run: ./gradlew clean rewriteDryRun |
Author
There was a problem hiding this comment.
try with clean to avoid regression like seen in: @Goooler
added 2 commits
January 10, 2026 20:31
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Pankraz76
commented
Jan 10, 2026
.github/workflows/ci.yml
Outdated
| - name: build (everything-but-maven) | ||
| if: matrix.kind == 'gradle' | ||
| run: ./gradlew build -x spotlessCheck -x rewriteDryRun -PSPOTLESS_EXCLUDE_MAVEN=true | ||
| run: ./gradlew clean build -PSPOTLESS_EXCLUDE_MAVEN=true |
Author
There was a problem hiding this comment.
test locally and partially on CI working assuming flaky build:
| uses: gradle/actions/setup-gradle@v5 | ||
| - name: build (maven-only) | ||
| if: matrix.kind == 'maven' | ||
| run: ./gradlew :plugin-maven:build -x spotlessCheck -x rewriteDryRun |
Author
There was a problem hiding this comment.
rewriteDryRun- we only call this on demand.
spotlessCheck- we do not reach here if not complain, could double check here or is this flaky as well, therefore excluded ?
added 9 commits
January 10, 2026 21:28
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Pankraz76
commented
Jan 10, 2026
| - name: Rewrite ♻️ | ||
| run: ./gradlew rewriteDryRun | ||
| - name: assemble testClasses | ||
| run: ./gradlew assemble testClasses |
Author
There was a problem hiding this comment.
is came into live as one job:
as its one dedicated goal why not run it also in dedicated job?
added 8 commits
January 10, 2026 21:54
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Author
|
IO:
com.diffplug.spotless.ThrowingEx$WrappedAsRuntimeException: java.io.IOException: Failed to load eclipse cdt formatter: java.lang.IllegalStateException: P2 operation already in progress, close other clients or delete stale lockfile at /home/runner/.m2/repository/dev/equo/p2-data/metadata/.lock |
added 6 commits
January 10, 2026 22:34
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Signed-off-by: Vincent Potucek <vpotucek@me.com> - https://docs.openrewrite.org/recipes/staticanalysis/codecleanup ``` There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by: org.openrewrite.staticanalysis.HideUtilityClassConstructor Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by: org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators Please review and commit the results. Estimate time saved: 15m ```
Member
|
Don't spam. I'm not sure why you introduced OpenRewrite. You really shouldn't use the 'clean' everywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[rewrite] add
CodeCleanup