Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

After conversing with Chatgpt, it seems like the reason this CI is failing is because of a leaked error code that doesn't get cleaned up.

The whole point of this CI test is to run tests on the diffpy.cmi dependencies srfit, srreal, pyobjcryst, and utils. All these tests pass when CI runs, but the CI still raises an error likely due to some error code leaking through.

I think we should probably have a conversation on if we even want this test. It seems redundant to me to test code from another repo where tests are (presumably) being ran, leading me to believe we don't need any of this CI testing.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.63%. Comparing base (06dec82) to head (5ce0654).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files           4        4           
  Lines         220      220           
=======================================
  Hits          206      206           
  Misses         14       14           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

The original rationale for the tests were to test that installation happened correctly. If the sub-package tests run, then code that uses the sub-packages should run. So there is value in these tests. IF we can think of another way of testing this, we could go there. For example, successfully importing everything from the sub-packages. It just seemed easier to run the tests from the sub-packages.

@sbillinge sbillinge merged commit f8c6f32 into diffpy:main Nov 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants