Skip to content

Conversation

@Barsnes
Copy link
Member

@Barsnes Barsnes commented Jan 20, 2026

resolves #1044
resolves #3348
resolves #4369
resolves #4433

Edit by @mimarz: Moved some links to resolving issues from other closed PRs which feat was moved to this PR instead.

Summary

First implementation of a new package that properly uses pure web, and has no dependencies like react.
Related to #1044

You can test this package with the npm tag test.


The preview comment is a bit buried, so putting links here as well:

Checks

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026

🦋 Changeset detected

Latest commit: 398c2a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@digdir/designsystemet-react Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet Patch
@digdir/designsystemet-types Patch
@digdir/designsystemet-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

unekinn and others added 8 commits January 20, 2026 13:26
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Co-authored-by: Oddbjørn Øvernes <oddbjorn.overnes@gmail.com>
…f Designsystemet (#4321)

Co-authored-by: Barsnes <tobias.barsnes@digdir.no>
Co-authored-by: Michael Marszalek <mimarz@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Marszalek <mimarz@gmail.com>
Co-authored-by: Michael Marszalek <mimarz@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

Preview deployments for this pull request:

storybook - 12. Feb 2026 - 16:24

themebuilder - 12. Feb 2026 - 16:24

www - 12. Feb 2026 - 16:31

eirikbacker and others added 2 commits February 11, 2026 09:31
Co-authored-by: Michael Marszalek <mimarz@gmail.com>
@@ -0,0 +1,4 @@
import '@digdir/designsystemet-css';
import '@digdir/designsystemet-theme';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume this was supposed to be theme file?

Suggested change
import '@digdir/designsystemet-theme';
import '@digdir/designsystemet-css/theme';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, and we should not merge this.
We augment in vite so we can use that import:
image

Copy link
Collaborator

@mimarz mimarz Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but why alias a deprecated package at not just use the new package/method for fetching theme, or for that matter just relative paths?


### Med command og uten context

Dersom du ikke vil bruke `Dialog.TriggerContext`, kan du bruke `command="show-modal"` eller `command="--show-non-modal"` og `commandfor="DIALOG-ID"` for å åpne dialogen fra en ekstern trigger.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this may be the first place some developers see command and commandfor, should we perhaps add a little info-box or something in these places invoker-commands are mentioned, that this is actually a new part of the web standard, link to the google developers post or mdn article, and note that we automatically polyfill this (I know it is mentioned in the readme, but it is maybe useful to include here as well)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

7 participants