-
Notifications
You must be signed in to change notification settings - Fork 45
fix: icons now scale when zooming in Safari #4484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…effect, replace with height/width where it had to fix scaling in Safari
🦋 Changeset detectedLatest commit: b1780fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: storybook - themebuilder - www - |
|
@oddvernes how strange. It scales fine in my Firefox (147.0.3) |
|
Weird, Im on same firefox, macbook. But its seems to mainly be noticeable at pretty high zoom like 200% (with cmd +) and above so it is not as bad as safari. perhaps it is flex-shrink or something |
| "@digdir/designsystemet-css": patch | ||
| --- | ||
|
|
||
| **Badge, Button, Spinner, Tabs, Tag**: Icons now scale in Safari when zooming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a side effect with how this was implemented that fontSize on the svg in these components now has an effect? Because I think it should be mentined here if so (considering how many examples there were of this in our own code)



Summary
Changes icon sizing css from using
font-size, which breaks scaling when zooming in Safari, to using height and widthFixes #4038
Checks
pnpm changesetif relevant)