Skip to content

Conversation

@dale-wahl
Copy link
Member

@dale-wahl dale-wahl commented Nov 30, 2023

This is merge-able!

  • Cartographer processor developed and functional; it allows, in principle, the creation of manifests (coordinate maps) that can be read and displayed by PixPlot. For the moment, I have it set to create a default grid mapping, but it should be easy to expand and add to if we would like to design different mappings.
  • This basic grid mapping is now done automatically (via preset) on downloading images. It then is used as a preview allowing users to easily explore their downloaded images!
  • I took and modified the PixPlot template and incorporated it into 4CAT. Primarily this means that it does not create a new static site (as PixPlot was designed) and instead loads them with our data (e.g., it uses the already downloaded images and templates instead of new hard-coded HTML files).

Notes:

  • The @app.route('/result/<path:query_file>') now can also load archived files. This may not be the best design and we might perhaps not archive the images since they have this new use. Recommend reviewing this part. Updated to open files and generate response on the fly.

To-do:

  • Cartographer options can be expanded and make it a bit easier to integrate new mappings.
  • I have done some basic editing to the PixPlot template, but it could benefit from more work. More editing done for 4CAT specific plots!
  • Particularly making certain features optional such as the "Hotspots" and some of the icons both of which are not used by default.
  • Add metadata to the Image descriptions
  • Move the image description panel to one of the sides; it works where it is with the image filename only, but is not great/intuitive with further descriptions
  • edit add presets for tiktok and telegram image downloaders

@dale-wahl dale-wahl requested a review from stijn-uva November 30, 2023 11:31
@dale-wahl
Copy link
Member Author

I merged master into cartographer again. Last week there were a few bugs. This week the only thing I saw was actually an issue with the master in that, if we allow unlimited images (e.g., max images is set to 0 in configuration), all the downloaders would use a max of 0 and thus always download all images!

There is this one super weird but and so far only visible on tiktok datasets...
image
I am not sure what's going on there, but it is only the thumbnails so I need to figure out why that is the case.

@dale-wahl
Copy link
Member Author

dale-wahl commented May 28, 2024

I merged master into cartographer again. Last week there were a few bugs. This week the only thing I saw was actually an issue with the master in that, if we allow unlimited images (e.g., max images is set to 0 in configuration), all the downloaders would use a max of 0 and thus always download all images!

There is this one super weird but and so far only visible on tiktok datasets... image I am not sure what's going on there, but it is only the thumbnails so I need to figure out why that is the case.

ok, ok. it actually just occurs when there are very few images. PixPlot itself fails if you have less than 12 (and our cartagrapher ignores/bypasses that). it seems to have to do with the zoom not being far enough away that it doesn't trigger the thumbnails. no idea how to fix or address... but yeah.

@sal-uva
Copy link
Collaborator

sal-uva commented Sep 11, 2024

Tried to run this, but getting some importing errors in JS:
image

@sal-uva
Copy link
Collaborator

sal-uva commented Sep 11, 2024

I would also suggest to rename the processor to something more specific. "Create Image visualisation" is a bit general; something like "Display images on Web page" is already a bit more concrete.

Relatedly, it is a bit unclear to me what can I do with the outputted zip file. Can the description be updated so users are told what they can do with it? And maybe add a readme file in the zip results?

As I understand it, the page opened by the "View" button is what's most interesting here right? Can't the zip file contain this page as well?

Otherwise good work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants