Generate .d.ts (declaration files) instead of using regular .ts files#104
Open
tahminator wants to merge 2 commits intodigitalocean:mainfrom
Open
Generate .d.ts (declaration files) instead of using regular .ts files#104tahminator wants to merge 2 commits intodigitalocean:mainfrom
tahminator wants to merge 2 commits intodigitalocean:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR updates the SDK to output
.d.tsfiles in place of.tsas is usually the norm for TypeScript library files.I made this PR because in my current project, I'm working on migrating our Bash scripts to Bun shell (& TS SDKs) and part of that includes moving our DigitalOcean infrastructure definitions to
dotsHowever, I'm currently running into an issue where the
.tsfiles are explicitly being checked bytsceven when being included in theexcludearray. From my research online, it seems like the fix is to useskipLibCheckbut that only works if your libraries are using declaration files instead of traditional TS source files.I manually ran a test where I generated
.d.tsfiles fromdotsinstead (andtrash'd all the.tsfiles) and it did seem to work:Before:

After:

I excluded
.tssource files from ending up in the final package by adding a.npmignorefile into the root dir, which should be enough