Skip to content

Fix assertion message #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YichiZhang0613 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix assertion message #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4740e2
Fix assertion message
YichiZhang0613 Nov 7, 2025
cc2c12f
Fix assertion message
YichiZhang0613 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/bounding_volume/aabb.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,14 +973,14 @@ impl BoundingVolume for Aabb {

#[inline]
fn loosen(&mut self, amount: Real) {
assert!(amount >= 0.0, "The loosening margin must be positive.");
assert!(amount >= 0.0, "The loosening margin must be non-negative.");
self.mins += Vector::repeat(-amount);
self.maxs += Vector::repeat(amount);
}

#[inline]
fn loosened(&self, amount: Real) -> Aabb {
assert!(amount >= 0.0, "The loosening margin must be positive.");
assert!(amount >= 0.0, "The loosening margin must be non-negative.");
Aabb {
mins: self.mins + Vector::repeat(-amount),
maxs: self.maxs + Vector::repeat(amount),
Expand All @@ -989,7 +989,7 @@ impl BoundingVolume for Aabb {

#[inline]
fn tighten(&mut self, amount: Real) {
assert!(amount >= 0.0, "The tightening margin must be positive.");
assert!(amount >= 0.0, "The tightening margin must be non-negative.");
self.mins += Vector::repeat(amount);
self.maxs += Vector::repeat(-amount);
assert!(
Expand All @@ -1000,7 +1000,7 @@ impl BoundingVolume for Aabb {

#[inline]
fn tightened(&self, amount: Real) -> Aabb {
assert!(amount >= 0.0, "The tightening margin must be positive.");
assert!(amount >= 0.0, "The tightening margin must be non-negative.");

Aabb::new(
self.mins + Vector::repeat(amount),
Expand Down
8 changes: 4 additions & 4 deletions src/bounding_volume/bounding_sphere.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ impl BoundingVolume for BoundingSphere {
/// ```
#[inline]
fn loosen(&mut self, amount: Real) {
assert!(amount >= 0.0, "The loosening margin must be positive.");
assert!(amount >= 0.0, "The loosening margin must be non-negative.");
self.radius += amount
}

Expand Down Expand Up @@ -509,7 +509,7 @@ impl BoundingVolume for BoundingSphere {
/// ```
#[inline]
fn loosened(&self, amount: Real) -> BoundingSphere {
assert!(amount >= 0.0, "The loosening margin must be positive.");
assert!(amount >= 0.0, "The loosening margin must be non-negative.");
BoundingSphere::new(self.center, self.radius + amount)
}

Expand Down Expand Up @@ -542,7 +542,7 @@ impl BoundingVolume for BoundingSphere {
/// ```
#[inline]
fn tighten(&mut self, amount: Real) {
assert!(amount >= 0.0, "The tightening margin must be positive.");
assert!(amount >= 0.0, "The tightening margin must be non-negative.");
assert!(amount <= self.radius, "The tightening margin is to large.");
self.radius -= amount
}
Expand Down Expand Up @@ -577,7 +577,7 @@ impl BoundingVolume for BoundingSphere {
/// ```
#[inline]
fn tightened(&self, amount: Real) -> BoundingSphere {
assert!(amount >= 0.0, "The tightening margin must be positive.");
assert!(amount >= 0.0, "The tightening margin must be non-negative.");
assert!(amount <= self.radius, "The tightening margin is to large.");
BoundingSphere::new(self.center, self.radius - amount)
}
Expand Down